Twitter | Pretraživanje | |
Saoirse Shipwreckt 31. sij
I still don’t understand why everyone blocks their CI on unimportant formatting lints
Reply Retweet Označi sa "sviđa mi se"
Saoirse Shipwreckt 31. sij
Odgovor korisniku/ci @withoutboats
When I want to make a small addition to a big project setting up the tool chain to run your linter locally is an enormous barrier to entry
Reply Retweet Označi sa "sviđa mi se"
Saoirse Shipwreckt 31. sij
Odgovor korisniku/ci @withoutboats
All of this so that I don’t include new lines some rule has decided are unnecessary??
Reply Retweet Označi sa "sviđa mi se"
Saoirse Shipwreckt
Not criticizing the rust compiler team here, this is standard practice across open source projects and I just don’t understand the obsession with “consistent formatting” - who cares??
Reply Retweet Označi sa "sviđa mi se" More
✕✕✕✕✕ 31. sij
Odgovor korisniku/ci @withoutboats
*raises hand*
Reply Retweet Označi sa "sviđa mi se"
corruption cat @ furnal equinox 31. sij
Odgovor korisniku/ci @withoutboats
it's nice for reviewers to not have to fuss about style and to let them focus on more important details like if something should be as_mut_thing or as_thing_mut
Reply Retweet Označi sa "sviđa mi se"
ʟʟoɢiq 31. sij
Odgovor korisniku/ci @withoutboats
If you don't see a problem, just add a git hook to rustfmt your changes on commit or at least push. Having a consistent formatting reduces clutter in the diffs and aids review.
Reply Retweet Označi sa "sviđa mi se"
Sam Wilson 31. sij
Odgovor korisniku/ci @withoutboats
I want consistent formatting, and I want git history to be clear and concise. I also don't want to deal with style debates. Having a style linter in CI is a very low effort fix for all of the above. Maybe adding a bot you can summon on a PR that fixes commits would help?
Reply Retweet Označi sa "sviđa mi se"
so this is what the future looks like 31. sij
Odgovor korisniku/ci @withoutboats
looks like this account is hacked
Reply Retweet Označi sa "sviđa mi se"
Sean Bowe 31. sij
Odgovor korisniku/ci @withoutboats
Some contributors will want to run cargo fmt on their code, and it’ll touch unrelated code in the PR if it wasn’t already formatted right. Also, sometimes the formatter is wrong and manual intervention is needed. Best to do it on a per contribution basis.
Reply Retweet Označi sa "sviđa mi se"