|
@withoutboats | |||||
|
Not criticizing the rust compiler team here, this is standard practice across open source projects and I just don’t understand the obsession with “consistent formatting” - who cares??
|
||||||
|
||||||
|
Saoirse Shipwreckt
@withoutboats
|
31. sij |
|
I still don’t understand why everyone blocks their CI on unimportant formatting lints
|
||
|
|
||
|
Saoirse Shipwreckt
@withoutboats
|
31. sij |
|
When I want to make a small addition to a big project setting up the tool chain to run your linter locally is an enormous barrier to entry
|
||
|
|
||
|
Saoirse Shipwreckt
@withoutboats
|
31. sij |
|
All of this so that I don’t include new lines some rule has decided are unnecessary??
|
||
|
|
||
|
✕✕✕✕✕
@peterbourgon
|
31. sij |
|
*raises hand*
|
||
|
|
||
|
corruption cat @ furnal equinox
@Gankra_
|
31. sij |
|
it's nice for reviewers to not have to fuss about style and to let them focus on more important details like if something should be as_mut_thing or as_thing_mut
|
||
|
|
||
|
ʟʟoɢiq
@llogiq
|
31. sij |
|
If you don't see a problem, just add a git hook to rustfmt your changes on commit or at least push.
Having a consistent formatting reduces clutter in the diffs and aids review.
|
||
|
|
||
|
Sam Wilson
@_SamWilsn_
|
31. sij |
|
I want consistent formatting, and I want git history to be clear and concise. I also don't want to deal with style debates.
Having a style linter in CI is a very low effort fix for all of the above.
Maybe adding a bot you can summon on a PR that fixes commits would help?
|
||
|
|
||
|
so this is what the future looks like
@offbyone
|
31. sij |
|
looks like this account is hacked
|
||
|
|
||
|
Sean Bowe
@ebfull
|
31. sij |
|
Some contributors will want to run cargo fmt on their code, and it’ll touch unrelated code in the PR if it wasn’t already formatted right. Also, sometimes the formatter is wrong and manual intervention is needed. Best to do it on a per contribution basis.
|
||
|
|
||