Twitter | Pretraživanje | |
Saoirse Shipwreckt
I still don’t understand why everyone blocks their CI on unimportant formatting lints
Reply Retweet Označi sa "sviđa mi se" More
Saoirse Shipwreckt 31. sij
Odgovor korisniku/ci @withoutboats
When I want to make a small addition to a big project setting up the tool chain to run your linter locally is an enormous barrier to entry
Reply Retweet Označi sa "sviđa mi se"
Saoirse Shipwreckt 31. sij
Odgovor korisniku/ci @withoutboats
All of this so that I don’t include new lines some rule has decided are unnecessary??
Reply Retweet Označi sa "sviđa mi se"
Saoirse Shipwreckt 31. sij
Odgovor korisniku/ci @withoutboats
Not criticizing the rust compiler team here, this is standard practice across open source projects and I just don’t understand the obsession with “consistent formatting” - who cares??
Reply Retweet Označi sa "sviđa mi se"
Pierre CHEVALIER 1. velj
Odgovor korisniku/ci @withoutboats
You can see formatting/linting as a barrier to entry as it's one more step for a new contributor. On the flip side, you can see it as one less mental barrier/distraction for an outsider to involve themselves in a codebase by reading its code. Code is read more than written.
Reply Retweet Označi sa "sviđa mi se"
Saoirse Shipwreckt 1. velj
Odgovor korisniku/ci @PierreCHEVALI15
Linting does not make code easier to read. Everyone is responding as if this absurd claim had not already occurred to me
Reply Retweet Označi sa "sviđa mi se"
Cecile Tonglet 🦀 1. velj
Odgovor korisniku/ci @withoutboats
Oh God I'm now working on a project where we don't use rustfmt, I waste some time doing manually the job of rustfmt
Reply Retweet Označi sa "sviđa mi se"
Cecile Tonglet 🦀 1. velj
Odgovor korisniku/ci @withoutboats
If you wonder why it's related to CI enforcing format it's because: a. the reviewer also waste some time with that too and b. if you use rustfmt without enforcing on the CI, your commits will include formatting of the previous commits and your Git history quickly becomes a mess
Reply Retweet Označi sa "sviđa mi se"
andy.unwrap() 31. sij
Odgovor korisniku/ci @withoutboats
My rule is only do this if you set up an easy way to run said linter that doesn’t require massive setup
Reply Retweet Označi sa "sviđa mi se"
Saoirse Shipwreckt 31. sij
Odgovor korisniku/ci @Andysomniac
Unfortunately even *instantiating the git sub modules* of rust-lang/rust is a substantial process
Reply Retweet Označi sa "sviđa mi se"
Eddy Bruel 31. sij
Odgovor korisniku/ci @withoutboats
To curb endless debates over coding style.
Reply Retweet Označi sa "sviđa mi se"
Saoirse Shipwreckt 31. sij
Odgovor korisniku/ci @ejpbruel
No shit. You could also just curb debates by adopting a policy of not caring
Reply Retweet Označi sa "sviđa mi se"