|
@withoutboats | |||||
|
I still don’t understand why everyone blocks their CI on unimportant formatting lints
|
||||||
|
||||||
|
Saoirse Shipwreckt
@withoutboats
|
31. sij |
|
When I want to make a small addition to a big project setting up the tool chain to run your linter locally is an enormous barrier to entry
|
||
|
|
||
|
Saoirse Shipwreckt
@withoutboats
|
31. sij |
|
All of this so that I don’t include new lines some rule has decided are unnecessary??
|
||
|
|
||
|
Saoirse Shipwreckt
@withoutboats
|
31. sij |
|
Not criticizing the rust compiler team here, this is standard practice across open source projects and I just don’t understand the obsession with “consistent formatting” - who cares??
|
||
|
|
||
|
Pierre CHEVALIER
@PierreCHEVALI15
|
1. velj |
|
You can see formatting/linting as a barrier to entry as it's one more step for a new contributor.
On the flip side, you can see it as one less mental barrier/distraction for an outsider to involve themselves in a codebase by reading its code.
Code is read more than written.
|
||
|
|
||
|
Saoirse Shipwreckt
@withoutboats
|
1. velj |
|
Linting does not make code easier to read. Everyone is responding as if this absurd claim had not already occurred to me
|
||
|
|
||
|
Cecile Tonglet 🦀
@CecileTonglet
|
1. velj |
|
Oh God I'm now working on a project where we don't use rustfmt, I waste some time doing manually the job of rustfmt
|
||
|
|
||
|
Cecile Tonglet 🦀
@CecileTonglet
|
1. velj |
|
If you wonder why it's related to CI enforcing format it's because: a. the reviewer also waste some time with that too and b. if you use rustfmt without enforcing on the CI, your commits will include formatting of the previous commits and your Git history quickly becomes a mess
|
||
|
|
||
|
andy.unwrap()
@Andysomniac
|
31. sij |
|
My rule is only do this if you set up an easy way to run said linter that doesn’t require massive setup
|
||
|
|
||
|
Saoirse Shipwreckt
@withoutboats
|
31. sij |
|
Unfortunately even *instantiating the git sub modules* of rust-lang/rust is a substantial process
|
||
|
|
||
|
Eddy Bruel
@ejpbruel
|
31. sij |
|
To curb endless debates over coding style.
|
||
|
|
||
|
Saoirse Shipwreckt
@withoutboats
|
31. sij |
|
No shit. You could also just curb debates by adopting a policy of not caring
|
||
|
|
||