Twitter | Pretraživanje | |
Dmitry Vyukov 23. sij
Welcome changes for kernel: and the mailing list version for contrast: Gerrit has side-by-side diffs, full expandable context, non-lossy comments attached to lines. Here are docs:
Reply Retweet Označi sa "sviđa mi se"
nedwill 23. sij
Odgovor korisniku/ci @dvyukov
Incredible! How does it relate to the email-based system now? Do actions on either gerrit/email mirrored?
Reply Retweet Označi sa "sviđa mi se"
Dmitry Vyukov
Well, as of now it's completely optional Annex to the process that is optional and does not affect anything. So you go to gerrit, review there, remember all comments in head then go to mailing list and post there [smiley or sad face on your choice].
Reply Retweet Označi sa "sviđa mi se" More
Dmitry Vyukov 24. sij
Odgovor korisniku/ci @NedWilliamson @Shiftreduce
But! I find even that useful, e.g. yesterday I got this: You cannot make sense nor meaningfully review it without context (and generally you cannot even apply it locally because you don't know base tree/revision).
Reply Retweet Označi sa "sviđa mi se"
nedwill 24. sij
Odgovor korisniku/ci @dvyukov @Shiftreduce
I agree, it is simply so much more readable. The email-based patches are super hard to review quickly without using local tools.
Reply Retweet Označi sa "sviđa mi se"