|
@dvyukov | |||||
|
@Shiftreduce Well, as of now it's completely optional Annex to the process that is optional and does not affect anything. So you go to gerrit, review there, remember all comments in head then go to mailing list and post there [smiley or sad face on your choice].
|
||||||
|
||||||
|
Dmitry Vyukov
@dvyukov
|
23. sij |
|
Welcome #Gerrit changes for #linux kernel:
linux-review.googlesource.com/c/virt/kvm/kvm…
and the mailing list version for contrast:
lore.kernel.org/lkml/202001231…
Gerrit has side-by-side diffs, full expandable context, non-lossy comments attached to lines.
Here are docs:
linux.googlesource.com/Documentation/…
|
||
|
|
||
|
nedwill
@NedWilliamson
|
23. sij |
|
Incredible! How does it relate to the email-based system now? Do actions on either gerrit/email mirrored?
|
||
|
|
||
|
Dmitry Vyukov
@dvyukov
|
24. sij |
|
But! I find even that useful, e.g. yesterday I got this:
groups.google.com/forum/#!topic/…
You cannot make sense nor meaningfully review it without context (and generally you cannot even apply it locally because you don't know base tree/revision).
|
||
|
|
||
|
nedwill
@NedWilliamson
|
24. sij |
|
I agree, it is simply so much more readable. The email-based patches are super hard to review quickly without using local tools.
|
||
|
|
||