|
@dvyukov | |||||
|
Welcome #Gerrit changes for #linux kernel:
linux-review.googlesource.com/c/virt/kvm/kvm…
and the mailing list version for contrast:
lore.kernel.org/lkml/202001231…
Gerrit has side-by-side diffs, full expandable context, non-lossy comments attached to lines.
Here are docs:
linux.googlesource.com/Documentation/…
|
||||||
|
||||||
|
Dmitry Vyukov
@dvyukov
|
23. sij |
|
And killer feature: version-to-version diffs with smart white-space highlighting:
linux-review.googlesource.com/c/virt/kvm/kvm…
You don't need to manually write up what's changed, and reviewers don't need to trust you blindly. And you see it's only whitespaces, not -whole-line/+whole-line.
|
||
|
|
||
|
nedwill
@NedWilliamson
|
23. sij |
|
Incredible! How does it relate to the email-based system now? Do actions on either gerrit/email mirrored?
|
||
|
|
||
|
Dmitry Vyukov
@dvyukov
|
24. sij |
|
@Shiftreduce Well, as of now it's completely optional Annex to the process that is optional and does not affect anything. So you go to gerrit, review there, remember all comments in head then go to mailing list and post there [smiley or sad face on your choice].
|
||
|
|
||
|
Ditmar Wendt
@DitmarWendt
|
23. sij |
|
is this automatic on new lkml patchsets, or manual and the community needs to adopt it? a better process like this would be so nice.
|
||
|
|
||
|
Dmitry Vyukov
@dvyukov
|
24. sij |
|
No, everything is manual and up to the patch author. Though, as reviewer you can apply a patch locally and upload to gerrit yourself. I did it for some larger changes that I wanted to _review_ rather than
just _stamp_.
|
||
|
|
||
|
thatreguy
@thatre_guy
|
24. sij |
|
Features a dark theme as well! pic.twitter.com/wSDV5G1NYI
|
||
|
|
||
|
Shift
@Shiftreduce
|
23. sij |
|
i wonder how it will affect patch cycles.
|
||
|
|
||