Twitter | Pretraživanje | |
Dmitry Vyukov
Welcome changes for kernel: and the mailing list version for contrast: Gerrit has side-by-side diffs, full expandable context, non-lossy comments attached to lines. Here are docs:
Reply Retweet Označi sa "sviđa mi se" More
Dmitry Vyukov 23. sij
Odgovor korisniku/ci @dvyukov
And killer feature: version-to-version diffs with smart white-space highlighting: You don't need to manually write up what's changed, and reviewers don't need to trust you blindly. And you see it's only whitespaces, not -whole-line/+whole-line.
Reply Retweet Označi sa "sviđa mi se"
nedwill 23. sij
Odgovor korisniku/ci @dvyukov
Incredible! How does it relate to the email-based system now? Do actions on either gerrit/email mirrored?
Reply Retweet Označi sa "sviđa mi se"
Dmitry Vyukov 24. sij
Odgovor korisniku/ci @NedWilliamson @Shiftreduce
Well, as of now it's completely optional Annex to the process that is optional and does not affect anything. So you go to gerrit, review there, remember all comments in head then go to mailing list and post there [smiley or sad face on your choice].
Reply Retweet Označi sa "sviđa mi se"
Ditmar Wendt 23. sij
Odgovor korisniku/ci @dvyukov
is this automatic on new lkml patchsets, or manual and the community needs to adopt it? a better process like this would be so nice.
Reply Retweet Označi sa "sviđa mi se"
Dmitry Vyukov 24. sij
Odgovor korisniku/ci @DitmarWendt
No, everything is manual and up to the patch author. Though, as reviewer you can apply a patch locally and upload to gerrit yourself. I did it for some larger changes that I wanted to _review_ rather than just _stamp_.
Reply Retweet Označi sa "sviđa mi se"
thatreguy 24. sij
Odgovor korisniku/ci @dvyukov
Features a dark theme as well!
Reply Retweet Označi sa "sviđa mi se"
Shift 23. sij
Odgovor korisniku/ci @dvyukov
i wonder how it will affect patch cycles.
Reply Retweet Označi sa "sviđa mi se"