Twitter | Pretraživanje | |
Alexander Popov 23. sij
Odgovor korisniku/ci @a13xp0p0v
[Jul 15] me: public friendly ping [Jul 16] Mr1: hey Mr2, it's for you! Mr2: I'm aware of the patch. It's on the list to investigate today. /* 10 days passed... Huh? */ [8/n]
Reply Retweet Označi sa "sviđa mi se"
Alexander Popov 23. sij
Odgovor korisniku/ci @a13xp0p0v
[Jul 26] Mr2: oh, this is fun. Not gonna take your fix. Whole code should be overwritten. I can worry about a proper fix for QEMU 4.2+. [Jul 27] me: hum, okay... Feel free to add me to CC, I can review the patches and test them with fuzzing! /* 3.5 months passed... */ [9/n]
Reply Retweet Označi sa "sviđa mi se"
Alexander Popov 23. sij
Odgovor korisniku/ci @a13xp0p0v
[Nov 6] me: I'm pointing politely to this issue again. It crashes qemu during syzkaller fuzzing. Why don't you apply my commit and then do the refactoring later when you want? [Nov 7] somebody in ML: do you want to rework the code yourself? [10/n]
Reply Retweet Označi sa "sviđa mi se"
Alexander Popov 23. sij
Odgovor korisniku/ci @a13xp0p0v
[Nov 7] me: huh, yes, I will take this task and return with a patch. /* Grr. Challenge accepted! A week of development. */ [Nov 14] me: new patch fixing IDE [Nov 21] Mr1: we have unit tests. First you improve them to cover all cases. Do according the IDE specification. [11/n]
Reply Retweet Označi sa "sviđa mi se"
Alexander Popov 23. sij
Odgovor korisniku/ci @a13xp0p0v
[Nov 27] me: okay, it looks like I can do that /* More work done. I developed a new IDE fix and a shiny unit-test that also found an extra DMA emulation bug */ [Dec 16] me: sent the patch series [12/n]
Reply Retweet Označi sa "sviđa mi se"
Alexander Popov 23. sij
Odgovor korisniku/ci @a13xp0p0v
[Dec 19] Mr1: No, your unit-test is slow. Make it faster. me: okay, I'll do that... /* More work done. Rrrrr! It must be finished! */ [13/n]
Reply Retweet Označi sa "sviđa mi se"
Alexander Popov 23. sij
Odgovor korisniku/ci @a13xp0p0v
[Dec 23] me: new fast shiny unit-test and fix [Dec 24] Mr2: I've been out to lunch for a little while. I'll review these series before the end of the year. [Dec 28] me: hello anybody? /* Silence. Happy New Year! No review. LOL!!! */ [14/n]
Reply Retweet Označi sa "sviđa mi se"
Alexander Popov 23. sij
Odgovor korisniku/ci @a13xp0p0v
Meanwhile my friends at 36C3 recommended to request a CVE to speed up the review process :-) Nice idea! Red Had likes CVEs! So MITRE allocated CVE-2019-20175 for this issue (with a DISPUTED tag). [15/n]
Reply Retweet Označi sa "sviđa mi se"
Alexander Popov 23. sij
Odgovor korisniku/ci @a13xp0p0v
[Jan 2] me: Happy New Year everyone! There is a CVE. How about review? /* 5 days passed */ [Jan 7] Mr1: okay, it's fine now. [Jan 8] me: thank you a lot! Let's wait for more reviews. /* 2 weeks passed */ [16/n]
Reply Retweet Označi sa "sviđa mi se"
Alexander Popov 23. sij
Odgovor korisniku/ci @a13xp0p0v
[Jan 22] me: pinging in the ML again about this fix and unit-test! [Jan 22] Mr1: I asked Mr2. He promised to take a look very soon! [Jan 23] Mr2: merged. WOW! Really?!! [17/n]
Reply Retweet Označi sa "sviđa mi se"
Alexander Popov
And now can you guess who created this bug back in 2015? Yes, it was Mr2. LOL! Maybe that is why he was delaying the fix that killed it. That was weird story. Hope you liked it. Happy end! ========================= [n/n]
Reply Retweet Označi sa "sviđa mi se" More
Alexander Popov 23. sij
Odgovor korisniku/ci @a13xp0p0v
And let me thank Mr1 once again! He is cool! I would not be able to become a QEMU contributor without his help :-) [n+1/n]
Reply Retweet Označi sa "sviđa mi se"
Pashk1n 23. sij
Odgovor korisniku/ci @a13xp0p0v
I (as a small contributor to Qemu IDE in the past) shed a tear at the end.. 😭😂
Reply Retweet Označi sa "sviđa mi se"
John Snow 23. sij
Odgovor korisniku/ci @a13xp0p0v
I'm sorry this was so frustrating for you; I could offer some excuses for why this was pushed to the bottom of the pile so often, but I know it won't make anything better.
Reply Retweet Označi sa "sviđa mi se"
John Snow 23. sij
Odgovor korisniku/ci @a13xp0p0v
In the end, I don't really have time to look at IDE code, nobody likes when I look at IDE code, but nobody else wants to take ownership of the module. The end result is patches languish.
Reply Retweet Označi sa "sviđa mi se"
Adrien 23. sij
Odgovor korisniku/ci @a13xp0p0v
I cant imagine all the feelings that you went through for this contribution. Hope, joy, frustration, helplessness, maybe anger... Thanks for all users :)
Reply Retweet Označi sa "sviđa mi se"