Twitter | Search | |
John Carmack
It is scary to look in some old code that hasn’t been touched in years, and see a completely non-thread-safe static global variable used
Reply Retweet Like More
Julio Carrettoni  28 May 13
Replying to @ID_AA_Carmack
true story. Specially when it's code you know it's on several different already shipped products :S
Reply Retweet Like
lemont 28 May 13
Replying to @ID_AA_Carmack
This! A fly in the proverbial ointment.
Reply Retweet Like
Zoleas 28 May 13
Replying to @ID_AA_Carmack
Isn't seeing a static global variable always scary? ;)
Reply Retweet Like
Henry Goffin 28 May 13
Replying to @ID_AA_Carmack
Story of my professional life.
Reply Retweet Like
David Goldfarb 28 May 13
I think it's safe to say what you find terrifying is probably limited to a subset of like four people.
Reply Retweet Like
Toad King 28 May 13
Replying to @ID_AA_Carmack
It's scary to look at most old code period.
Reply Retweet Like
Reed Tucker 28 May 13
Replying to @ID_AA_Carmack
Reply Retweet Like
Tim Meers 28 May 13
So in other words all of the production code here?
Reply Retweet Like
Bladelaw 28 May 13
Replying to @ID_AA_Carmack
nothing like finding an old landmine
Reply Retweet Like
⁧ シーク⁨Sik 28 May 13
Replying to @ID_AA_Carmack
If that's the biggest of your problems then I wonder what you'd think of ptr-to-int conversions or using C's basic types...
Reply Retweet Like
Richard Minerich 28 May 13
Glad I'm not working there :)
Reply Retweet Like
Tim Meers 28 May 13
hey no worries, it's all serial async in VB6, so it's all safe.....
Reply Retweet Like
Rolf 28 May 13
Replying to @ID_AA_Carmack
Dilemma. Leave it because it works, or fix it and break it.
Reply Retweet Like
Ben Quintero( •̀_•́) 28 May 13
Replying to @ID_AA_Carmack
This has been the source of nearly every bug I've had with porting serial code to multi-core...
Reply Retweet Like
Jonathan Blow 28 May 13
Replying to @ID_AA_Carmack
I wonder if it's worth hacking 'static storage for variables without some naming prefix is an error' into LLVM as a test.
Reply Retweet Like
Jonathan Blow 28 May 13
Replying to @ID_AA_Carmack
Plus perhaps something like ThisFileIsAllowedToHaveGlobals ... or actually, maybe that is all you need.
Reply Retweet Like
Jonathan Blow 28 May 13
Replying to @ID_AA_Carmack
GlobalsAllowedHere ... GlobalsNoLongerAllowed . Then every global/static that gets compiled in is searchable.
Reply Retweet Like
Jet Fury 28 May 13
Reply Retweet Like