Twitter | Search | |
John Carmack
It is scary to look in some old code that hasn’t been touched in years, and see a completely non-thread-safe static global variable used
Reply Retweet Like More
Julio Carrettoni  28 May 13
Replying to @ID_AA_Carmack
true story. Specially when it's code you know it's on several different already shipped products :S
Reply Retweet Like
Lemont 28 May 13
Replying to @ID_AA_Carmack
This! A fly in the proverbial ointment.
Reply Retweet Like
Zoleas 28 May 13
Replying to @ID_AA_Carmack
Isn't seeing a static global variable always scary? ;)
Reply Retweet Like
Henry Goffin 28 May 13
Replying to @ID_AA_Carmack
Story of my professional life.
Reply Retweet Like
Toad King 28 May 13
Replying to @ID_AA_Carmack
It's scary to look at most old code period.
Reply Retweet Like
Tim Meers 28 May 13
So in other words all of the production code here?
Reply Retweet Like
Bladelaw 28 May 13
Replying to @ID_AA_Carmack
nothing like finding an old landmine
Reply Retweet Like
⁧ シーク⁨Sik 28 May 13
Replying to @ID_AA_Carmack
If that's the biggest of your problems then I wonder what you'd think of ptr-to-int conversions or using C's basic types...
Reply Retweet Like
Richard Minerich 28 May 13
Glad I'm not working there :)
Reply Retweet Like
Tim Meers 28 May 13
hey no worries, it's all serial async in VB6, so it's all safe.....
Reply Retweet Like
Myles Fowler 28 May 13
Amazes me what you find terrifying.
Reply Retweet Like
Rolf 28 May 13
Replying to @ID_AA_Carmack
Dilemma. Leave it because it works, or fix it and break it.
Reply Retweet Like
Kyle 28 May 13
you should make a game where the player has to communicate through a non-thread-safe static global variable
Reply Retweet Like
Jet Fury 28 May 13
Reply Retweet Like
Joe Ludwig 28 May 13
usually those things have a comment about fixing them after shipping written by someone no longer at the company
Reply Retweet Like
Arrrrrrrrrrrgh 28 May 13
Replying to @ID_AA_Carmack
beware of Schrödinbugs! *read code* "WTF? This code couldn't possibly work!" *alarms as software begins failing in the field*
Reply Retweet Like
Ivan Reese 28 May 13
By using as a hash tag, you’re putting this conversation in global scope.
Reply Retweet Like
J 28 May 13
Maybe you can get a quick approximation of this by carefully grepping a symbol dump of the binary?
Reply Retweet Like
John Carmack 28 May 13
Replying to @Jonathan_Blow
yes, I would like to be able to require a on a per file basis to allow any static variables.
Reply Retweet Like