|
@DitmarWendt | |||||
|
is this automatic on new lkml patchsets, or manual and the community needs to adopt it? a better process like this would be so nice.
|
||||||
|
||||||
|
Dmitry Vyukov
@dvyukov
|
23. sij |
|
Welcome #Gerrit changes for #linux kernel:
linux-review.googlesource.com/c/virt/kvm/kvm…
and the mailing list version for contrast:
lore.kernel.org/lkml/202001231…
Gerrit has side-by-side diffs, full expandable context, non-lossy comments attached to lines.
Here are docs:
linux.googlesource.com/Documentation/…
|
||
|
|
||
|
Ditmar Wendt
@DitmarWendt
|
23. sij |
|
also, quick q - say there's patch v1, and patch v2, can gerritt show the difference between these two patches (or is it still a case of apply both to two clones of the original, diff those)
|
||
|
|
||
|
Ditmar Wendt
@DitmarWendt
|
23. sij |
|
whoops yes it, "version-to-version diffs" like you said are exactly that. cool!
linux-review.googlesource.com/c/virt/kvm/kvm…
|
||
|
|
||
|
Dmitry Vyukov
@dvyukov
|
24. sij |
|
No, everything is manual and up to the patch author. Though, as reviewer you can apply a patch locally and upload to gerrit yourself. I did it for some larger changes that I wanted to _review_ rather than
just _stamp_.
|
||
|
|
||
|
Han-Wen Nienhuys
@Nienhuys
|
24. sij |
|
Would you want this to be automatic?
|
||
|
|
||