Twitter | Pretraživanje | |
Dmitry Vyukov 23. sij
Welcome changes for kernel: and the mailing list version for contrast: Gerrit has side-by-side diffs, full expandable context, non-lossy comments attached to lines. Here are docs:
Reply Retweet Označi sa "sviđa mi se"
Ditmar Wendt
is this automatic on new lkml patchsets, or manual and the community needs to adopt it? a better process like this would be so nice.
Reply Retweet Označi sa "sviđa mi se" More
Ditmar Wendt 23. sij
Odgovor korisniku/ci @dvyukov
also, quick q - say there's patch v1, and patch v2, can gerritt show the difference between these two patches (or is it still a case of apply both to two clones of the original, diff those)
Reply Retweet Označi sa "sviđa mi se"
Ditmar Wendt 23. sij
Odgovor korisniku/ci @dvyukov
whoops yes it, "version-to-version diffs" like you said are exactly that. cool!
Reply Retweet Označi sa "sviđa mi se"
Dmitry Vyukov 24. sij
Odgovor korisniku/ci @DitmarWendt
No, everything is manual and up to the patch author. Though, as reviewer you can apply a patch locally and upload to gerrit yourself. I did it for some larger changes that I wanted to _review_ rather than just _stamp_.
Reply Retweet Označi sa "sviđa mi se"
Han-Wen Nienhuys 24. sij
Odgovor korisniku/ci @DitmarWendt @dvyukov
Would you want this to be automatic?
Reply Retweet Označi sa "sviđa mi se"